Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix flakiness in integration/bazel by disabling symlinked_node… #35804

Closed
wants to merge 1 commit into from
Closed

build: fix flakiness in integration/bazel by disabling symlinked_node… #35804

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Contributor

…_modules

The flakiness in integration/bazel-schematics is going to be a bit tricker as the WORKSPACE file is JIT generated by the architect build layer

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from IgorMinar March 2, 2020 19:10
@gregmagolan
build: fix flakiness in integration/bazel by disabling symlinked_node…
76fbb64 
…_modules

The flakiness in integration/bazel-schematics is going to be a bit tricker as the WORKSPACE file is JIT generated by the architect build layer
josephperrott
josephperrott approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Mar 2, 2020
@ngbot ngbot bot modified the milestone: needsTriage Mar 2, 2020
@gregmagolan gregmagolan mentioned this pull request Mar 2, 2020
Closed
14 tasks
@atscott atscott closed this in ef2721b Mar 2, 2020
atscott pushed a commit that referenced this pull request Mar 2, 2020
@gregmagolan @atscott
build: fix flakiness in integration/bazel by disabling symlinked_node…
371a973 
…_modules (#35804)

The flakiness in integration/bazel-schematics is going to be a bit tricker as the WORKSPACE file is JIT generated by the architect build layer

PR Close #35804
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gregmagolan @josephperrott @googlebot